fix(*): fix deps and build process #434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vue Composition API
When utilizing the
@vue/composition-api
inside of a Kongponent package, the@vue/composition-api
needs to be added as apeerDependency
to the component package rather than adependency
.You will need to manually add the
peerDependencies
entry inside the individual component'spackage.json
. For example, inside./packages/KTable/package.json
this is what was addedThe parent application must then manually add
@vue/composition-api
to it'spackage.json
as a dependency if utilizing any of the components depending on the package (this is now outlined in the docs for each corresponding component, currentlyKTable
andKCardCatalog
).This is required as the component must use the same instance of the plugin as the parent application, meaning that the plugin has to be added to the parent application's dependencies. This is further outlined in an issue on the composition api repo.
The quote above, taken from the issue, means that we should plan to upgrade Kongponents (and any parent Kong-owned applications, such as
khcp
,kong-admin
, etc.) to2.7
when released, which will make utilizing the library easier on the user.Build Process
Update the build process to copy necessary config files in a separate step, leaving them in place until
yarn build:cli
finishes, then remove from the individual/package/*
directories, as other steps in the build process will fail ifpostcss.config.js
files are not left in place (e.g. inKIcon
package) until the completion of all package builds.Docs
Update docs for
KTable
andKCardCatalog
for usage with Composition API.PR Checklist